Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log service link error only on debug flag #1600

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: log service link error only on debug flag #1600

merged 1 commit into from
Oct 23, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 23, 2023 •
edited
Loading

What kind of change does this PR introduce?

Bug fix #1599

What is the new behavior?

Since the error is non-fatal, only emit the log when debug flag is on.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner October 23, 2023 07:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6610028720

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 56.908%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
internal/link/link.go 12 79.21%
Totals Coverage Status
Change from base Build 6603581180: -0.2%
Covered Lines: 5186
Relevant Lines: 9113
💛 - Coveralls

@sweatybridge sweatybridge merged commit f1f0d45 into main Oct 23, 2023
10 checks passed
@sweatybridge sweatybridge deleted the warn-debug branch October 23, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

supabase link returns 404 on route /version
3 participants
@sweatybridge @coveralls @kamilogorek