Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace all localhost instances with 127.0.0.1 #1595

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

kamilogorek
Copy link
Member

Essentially s/localhost/127.0.0.1/g. Using localhost can be flaky due to cli running in various environments and this will potentially fix some random network issues that has been reported.

We don't want to perform a lookup on localhost as it will go to IPv6 first, where we always want to use IPv4 instead.

@kamilogorek kamilogorek requested a review from a team as a code owner October 20, 2023 20:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6592371308

  • 28 of 34 (82.35%) changed or added relevant lines in 11 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 57.035%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/diff/diff.go 0 1 0.0%
internal/db/start/start.go 2 3 66.67%
internal/utils/flags/db_url.go 0 1 0.0%
internal/start/start.go 11 14 78.57%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6557313119: -0.03%
Covered Lines: 5197
Relevant Lines: 9112

💛 - Coveralls

@sweatybridge sweatybridge changed the title ref: Replace all localhost instances with 127.0.0.1 fix: replace all localhost instances with 127.0.0.1 Oct 21, 2023
@sweatybridge sweatybridge merged commit 9d801ee into main Oct 21, 2023
10 checks passed
@sweatybridge sweatybridge deleted the replace-localhost branch October 21, 2023 02:42
@sweatybridge
Copy link
Contributor

sweatybridge commented Oct 21, 2023

Thanks! This could potentially resolve #1574

I've renamed the PR title to trigger a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants