Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable cancel context for management apis #1585

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 17, 2023

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Sets cancellable context in root command. Currently context is only cancellable if run with --debug flag.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner October 17, 2023 08:02
@coveralls
Copy link

coveralls commented Oct 17, 2023

Pull Request Test Coverage Report for Build 6544255454

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 57.124%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/functions.go 0 2 0.0%
cmd/root.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/root.go 1 16.13%
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6530476829: 0.006%
Covered Lines: 5204
Relevant Lines: 9110

💛 - Coveralls

@sweatybridge sweatybridge merged commit 1d274ba into main Oct 17, 2023
8 checks passed
@sweatybridge sweatybridge deleted the fix-cancel branch October 17, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants