Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): clarify need for commas in schema flag of db commands #1545

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

mikelhamer
Copy link
Contributor

What kind of change does this PR introduce?

docs update

Additional context

As a first time user and CLI noob, it took me a bit to figure out the list of schema had to be comma separated, so I thought it would be useful to add this bit to the docs. This is consistent with other parts of the docs such as the description of domains flag in the sso add command.

@mikelhamer mikelhamer requested a review from a team as a code owner October 4, 2023 04:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6401656368

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 56.714%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6400777196: -0.03%
Covered Lines: 5102
Relevant Lines: 8996

💛 - Coveralls

@sweatybridge sweatybridge changed the title docs: clarify need for commas in schema flag of db commands chore(docs): clarify need for commas in schema flag of db commands Oct 4, 2023
Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! definitely clearer than before

@sweatybridge sweatybridge merged commit 9cf594c into supabase:main Oct 4, 2023
@mikelhamer
Copy link
Contributor Author

Awesome :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants