Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commands to get and update root encryption key #1541

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 2, 2023

What kind of change does this PR introduce?

feature

What is the new behavior?

Syncs linked project's root encryption key to another new project

supabase vault get-root-key | supabase vault update-root-key --project <new_project_ref>

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner October 2, 2023 06:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6376940149

  • 6 of 36 (16.67%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 56.598%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/rootKey.go 6 12 50.0%
internal/root_key/get/get.go 0 10 0.0%
internal/root_key/update/update.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6375785582: -0.2%
Covered Lines: 5018
Relevant Lines: 8866

💛 - Coveralls

@soedirgo
Copy link
Member

soedirgo commented Oct 2, 2023

This is specifically pgsodium root key though - might be worth qualifying that?

@sweatybridge
Copy link
Contributor Author

This is specifically pgsodium root key though - might be worth qualifying that?

I thought about that but didn't want to mention the name of extensions in cli command, due to the risk of future compatibility issues like extension renaming or deprecation.

How about supabase vault get-root-key because it aligns with our product offering and is less likely to change.

@soedirgo
Copy link
Member

soedirgo commented Oct 3, 2023

Yeah sgtm

@sweatybridge sweatybridge merged commit aa52e0c into main Oct 3, 2023
10 checks passed
@sweatybridge sweatybridge deleted the root-key branch October 3, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants