-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: container network aliases #1510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6387944488
💛 - Coveralls |
gregnr
commented
Sep 20, 2023
@sweatybridge I've refactored the code to:
|
gregnr
commented
Sep 28, 2023
sweatybridge
approved these changes
Sep 29, 2023
sweatybridge
changed the title
Container network aliases
feat: container network aliases
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds network aliases to each container. Makes networking between containers easier during local development.
For example, to invoke an edge function from Postgres using
pg_net
, now all you need is:instead of trying to determine the container host name
http://supabase_kong_my-supabase-project:8000
.Alternatives
Another option would be to use
http://host.docker.internal:54321
to route packets through the host, though unsure if this DNS host is supported by all container runtimes.Long term solution
These are all more short-term solutions - the best solution would be to provide something like:
within Postgres to grab the project URL dynamically, regardless of environment (local, preview, prod) like we do with Edge Function default secrets.