Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor connect by config to identify localhost #1505

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Sep 19, 2023

What kind of change does this PR introduce?

Bug fix #1588 (comment)

What is the new behavior?

  • fixes migration up --linked not connecting to remote
  • fixes inspect <...> --local not connecting to local
  • fixes db pull --local not connecting to local
  • fixes localhost check for migration squash

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge marked this pull request as ready for review October 25, 2023 05:47
@sweatybridge sweatybridge requested a review from a team as a code owner October 25, 2023 05:47
@sweatybridge sweatybridge changed the title chore: refactor connect by config to identify localhost fix: refactor connect by config to identify localhost Oct 25, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6650292980

  • 23 of 48 (47.92%) changed or added relevant lines in 30 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 58.595%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/migration.go 0 1 0.0%
internal/db/diff/migra.go 2 3 66.67%
internal/inspect/bloat/bloat.go 0 1 0.0%
internal/inspect/blocking/blocking.go 0 1 0.0%
internal/inspect/cache/cache.go 0 1 0.0%
internal/inspect/calls/calls.go 0 1 0.0%
internal/inspect/index_sizes/index_sizes.go 0 1 0.0%
internal/inspect/index_usage/index_usage.go 0 1 0.0%
internal/inspect/locks/locks.go 0 1 0.0%
internal/inspect/long_running_queries/long_running_queries.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/migration/list/list.go 3 94.49%
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6650160053: -0.05%
Covered Lines: 5665
Relevant Lines: 9668

💛 - Coveralls

@sweatybridge sweatybridge merged commit 7f64b4e into main Oct 26, 2023
8 checks passed
@sweatybridge sweatybridge deleted the ref-url branch October 26, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to link to a project on expo react-native
2 participants