fix: ignore missing table when listing remote migrations (#2573)

fix: handle pgx query error in one place
supabase · Jul 29, 2024 · a923832 · a923832
1 parent 1dedb59
commit a923832
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/pkg/migration/list.go b/pkg/migration/list.go
@@ -18,10 +18,7 @@ import (
 
 func ListRemoteMigrations(ctx context.Context, conn *pgx.Conn) ([]string, error) {
 	// We query the version string only for backwards compatibility
-	rows, err := conn.Query(ctx, LIST_MIGRATION_VERSION)
-	if err != nil {
-		return nil, errors.Errorf("failed to query rows: %w", err)
-	}
+	rows, _ := conn.Query(ctx, LIST_MIGRATION_VERSION)
 	versions, err := pgxv5.CollectStrings(rows)
 	if err != nil {
 		var pgErr *pgconn.PgError

diff --git a/pkg/pgxv5/rows.go b/pkg/pgxv5/rows.go
@@ -11,6 +11,7 @@ import (
 )
 
 func CollectStrings(rows pgx.Rows) ([]string, error) {
+	defer rows.Close()
 	result := []string{}
 	for rows.Next() {
 		var version string