Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: introduce mandatory 100% coverage of crypto subpackage #1891

Closed
wants to merge 0 commits into from
Closed

ci: introduce mandatory 100% coverage of crypto subpackage #1891

wants to merge 0 commits into from

Conversation

hf
Copy link
Contributor

@hf hf commented Dec 24, 2024

To prevent problems like the ones in #1887, a mandatory 100% coverage is required in the crypto subpackage.

@hf hf requested a review from a team as a code owner December 24, 2024 13:57
@hf hf force-pushed the hf/introduce-mandatory-100-coverage branch from 98d168a to 987c500 Compare December 24, 2024 17:47
kangmingtay
kangmingtay approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@kangmingtay kangmingtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending the merge of #1892

@hf hf closed this Jan 10, 2025
@hf hf force-pushed the hf/introduce-mandatory-100-coverage branch from 987c500 to 174198e Compare January 10, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hf @kangmingtay