Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email_verified field not being updated on signup confirmation #1868

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12289970528

Details

  • 10 of 18 (55.56%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 57.266%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/models/user.go 3 5 60.0%
internal/api/verify.go 7 13 53.85%
Totals Coverage Status
Change from base Build 12289608862: -0.002%
Covered Lines: 9706
Relevant Lines: 16949

💛 - Coveralls

Copy link
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a comment for a couple considerations.

internal/api/verify.go Show resolved Hide resolved
@kangmingtay kangmingtay force-pushed the km/fix-email-verified branch from 9bec9af to 5ddfe54 Compare December 12, 2024 04:19
@kangmingtay kangmingtay force-pushed the km/fix-email-verified branch from 5ddfe54 to 601f998 Compare December 12, 2024 04:41
@kangmingtay kangmingtay merged commit 483463e into master Dec 12, 2024
2 checks passed
@kangmingtay kangmingtay deleted the km/fix-email-verified branch December 12, 2024 04:49
hf pushed a commit that referenced this pull request Dec 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.165.1](v2.165.0...v2.165.1)
(2024-12-19)


### Bug Fixes

* check if session is nil
([#1873](#1873))
([fd82601](fd82601))
* email_verified field not being updated on signup confirmation
([#1868](#1868))
([483463e](483463e))
* handle user banned error code
([#1851](#1851))
([a6918f4](a6918f4))
* Revert "fix: revert fallback on btree indexes when hash is
unavailable" ([#1859](#1859))
([9fe5b1e](9fe5b1e))
* skip cleanup for non-2xx status
([#1877](#1877))
([f572ced](f572ced))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hf pushed a commit that referenced this pull request Dec 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.166.0](v2.165.0...v2.166.0)
(2024-12-23)


### Features

* switch to googleapis/release-please-action, bump to 2.166.0
([#1883](#1883))
([11a312f](11a312f))


### Bug Fixes

* check if session is nil
([#1873](#1873))
([fd82601](fd82601))
* email_verified field not being updated on signup confirmation
([#1868](#1868))
([483463e](483463e))
* handle user banned error code
([#1851](#1851))
([a6918f4](a6918f4))
* Revert "fix: revert fallback on btree indexes when hash is
unavailable" ([#1859](#1859))
([9fe5b1e](9fe5b1e))
* skip cleanup for non-2xx status
([#1877](#1877))
([f572ced](f572ced))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hf added a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants