Skip to content

Commit

Permalink
code review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
wtbarnes committed Sep 25, 2024
1 parent 6ccd9ef commit c73030f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sunkit_instruments/response/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
A subpackage for computing instrument responses
"""

from sunkit_instruments.response.thermal import *
from sunkit_instruments.response.thermal import SourceSpectra, get_temperature_response
11 changes: 10 additions & 1 deletion sunkit_instruments/response/thermal.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,18 @@ def get_temperature_response(channel, spectra, obstime=None):
Parameters
----------
channel: `~sunkit_instruments.`
channel: `~sunkit_instruments.response.abstractions.AbstractChannel`
spectra: `~sunkit_instruments.response.SourceSpectra`
obstime: any format parsed by `sunpy.time.parse_time`, optional
Returns
-------
temperature: `~astropy.units.Quantity`
response: `~astropy.units.Quantity`
See Also
--------
sunkit_instruments.response.SourceSpectra.temperature_response
"""
return spectra.temperature, spectra.temperature_response(channel, obstime=obstime)

Check warning on line 31 in sunkit_instruments/response/thermal.py

View check run for this annotation

Codecov / codecov/patch

sunkit_instruments/response/thermal.py#L31

Added line #L31 was not covered by tests

Expand Down

0 comments on commit c73030f

Please sign in to comment.