feat: turn into up-to-date CRA template #26
Conversation
There was a problem hiding this comment.
Amazing job @felixjung !
Can we move this project to the sumup-oss ?
|
Friends, could you please take this for a spin? To do so, check out the branch and run where There is a slight issue with linting. 😓 Because we want to provide a foundry linter config to the bootstrapped project, ESLint picks it up from |
|
I fixed the ESLint issues and also fixed the test template. Would be good if you gave it another try. Should all work as expected now. |
| // If you want to start measuring performance in your app, pass a function | ||
| // to log results (for example: reportWebVitals(console.log)) | ||
| // or send to an analytics endpoint. Learn more: https://bit.ly/CRA-vitals | ||
| reportWebVitals(); |
There was a problem hiding this comment.
I assume this is a CRA feature, right? Would there be a benefit in using our own signal library instead?
There was a problem hiding this comment.
Yes, this is part of CRA. I think it would be cool to use signal. Would there be any restrictions on how that can be used and how it needs to be configured?
There was a problem hiding this comment.
Hm, yes, the configuration is more involved than I thought.
TL;DR: You need to generate your own script and inline it.
|
OK, by opting for running |
Co-authored-by: Connor Bär <[email protected]>
Co-authored-by: Connor Bär <[email protected]>
felixjung
force-pushed
the
cra-template
branch
from
d820edf to
b33e7d9
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Addresses #issue-number.
Purpose
This PR updates all SumUp dependencies and turns the project into a custom CRA template. With a CRA template users will be able to bootstrap an app by running
yarn create react-app --template @sumup. Please refer to the updated README for details.Definition of done
BREAKING CHANGE: This change is similar to a complete rewrite.