Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intl-format-cache dependency #270

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Remove intl-format-cache dependency #270

merged 2 commits into from
Oct 17, 2024

Conversation

connor-baer
Copy link
Member

Purpose

The intl-format-cache is unmaintained and incompatible with ES modules due to its bundling.

Approach and changes

  • Write a custom memoize function inspired by intl-format-cache

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the bug Something isn't working label Oct 17, 2024
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: bd0e066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup-oss/intl Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.48%. Comparing base (12da01b) to head (bd0e066).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/memoize.ts 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   93.46%   93.48%   +0.01%     
==========================================
  Files          15       16       +1     
  Lines         689      721      +32     
  Branches       85       97      +12     
==========================================
+ Hits          644      674      +30     
- Misses         43       45       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer merged commit 44ad012 into main Oct 17, 2024
2 checks passed
@connor-baer connor-baer deleted the fix/intl-cache-esm branch October 17, 2024 20:04
@connor-baer connor-baer mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant