Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types to allow Temporal objects #266

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Oct 10, 2024

Purpose

#250 added support for passing Temporal objects to the date and time formatting functions. Unfortunately, I forgot to update the types, so TypeScript still complains.

Approach and changes

  • Update the types to allow passing relevant Temporal objects to the date and time formatting functions. The types are strict to prevent accidentally passing date-only objects to a time formatting function and vice versa.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the bug Something isn't working label Oct 10, 2024
@connor-baer connor-baer requested a review from sirineJ October 10, 2024 12:21
Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 0311b47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup-oss/intl Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@connor-baer connor-baer changed the title Allow Temporal objects Update types to allow Temporal objects Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (b1147e1) to head (0311b47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   93.23%   93.46%   +0.23%     
==========================================
  Files          15       15              
  Lines         665      689      +24     
  Branches       84       85       +1     
==========================================
+ Hits          620      644      +24     
  Misses         43       43              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/types/index.ts Outdated Show resolved Hide resolved
@connor-baer connor-baer merged commit d817935 into main Oct 11, 2024
4 checks passed
@connor-baer connor-baer deleted the fix/temporal-types branch October 11, 2024 11:44
@connor-baer connor-baer mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants