Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable security/detect-object-injection rule #928

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

connor-baer
Copy link
Member

Purpose

This rule produces too many false positives.

Approach and changes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

This rule produces too many false positives.
@connor-baer connor-baer requested a review from a team as a code owner January 24, 2024 09:40
@connor-baer connor-baer requested review from tareqlol and removed request for a team January 24, 2024 09:40
Copy link

changeset-bot bot commented Jan 24, 2024

⚠️ No Changeset found

Latest commit: 3b7637e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a39c58) 63.93% compared to head (3b7637e) 63.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #928      +/-   ##
==========================================
+ Coverage   63.93%   63.96%   +0.03%     
==========================================
  Files          29       29              
  Lines        2257     2259       +2     
  Branches      122      122              
==========================================
+ Hits         1443     1445       +2     
  Misses        804      804              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer merged commit eb43166 into next Jan 24, 2024
8 checks passed
@connor-baer connor-baer deleted the feature/tweak-security branch January 24, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant