Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Jest to Vitest #913

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Switch from Jest to Vitest #913

merged 4 commits into from
Dec 1, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Dec 1, 2023

Purpose

Jest's abysmal support for ESM blocks the upgrade to Prettier v3 (#912). Switching to Vitest magically solves these issues and simplifies the codebase.

Approach and changes

  • Uninstall Jest and install Vitest
  • Migrate the test files to Vitest's API

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: fc7a5fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (638b4ed) 68.26% compared to head (0720cc0) 63.45%.

❗ Current head 0720cc0 differs from pull request most recent head fc7a5fc. Consider uploading reports for the commit fc7a5fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #913      +/-   ##
==========================================
- Coverage   68.26%   63.45%   -4.82%     
==========================================
  Files          18       26       +8     
  Lines         375     1970    +1595     
  Branches       64       95      +31     
==========================================
+ Hits          256     1250     +994     
- Misses        110      712     +602     
+ Partials        9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer marked this pull request as ready for review December 1, 2023 14:00
@connor-baer connor-baer requested a review from a team as a code owner December 1, 2023 14:00
@connor-baer connor-baer requested review from tareqlol and removed request for a team December 1, 2023 14:00
@connor-baer connor-baer merged commit 7d49597 into next Dec 1, 2023
3 checks passed
@connor-baer connor-baer deleted the chore/vitest branch December 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant