Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages (next) #904

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Version Packages (next) #904

merged 3 commits into from
Dec 1, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Nov 10, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

next is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on next.

⚠️⚠️⚠️⚠️⚠️⚠️

Releases

@sumup/[email protected]

Major Changes

@connor-baer connor-baer requested a review from a team as a code owner November 10, 2023 10:00
@connor-baer connor-baer requested review from tareqlol and removed request for a team November 10, 2023 10:00
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e9d2c2) 68.26% compared to head (2b5f6df) 68.26%.

❗ Current head 2b5f6df differs from pull request most recent head fa4592a. Consider uploading reports for the commit fa4592a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #904   +/-   ##
=======================================
  Coverage   68.26%   68.26%           
=======================================
  Files          18       18           
  Lines         375      375           
  Branches       64       64           
=======================================
  Hits          256      256           
  Misses        110      110           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix attribution for @hilleer in the changelog.

@hilleer
Copy link
Contributor

hilleer commented Nov 13, 2023

Need to fix attribution for @hilleer in the changelog.

@connor-baer do I need to do anything? 👀

@connor-baer
Copy link
Member Author

@hilleer No, I'll take care of it before I merge the PR. Changesets wrongly attributed the contribution to me because I added the changeset and I want to make sure you get the credit.

The added plugin is a breaking change because it might require users to make changes to their codebase. That's why I plan to release it as a new major, but I'd like to make a couple of other changes first, like updating dependencies.

@github-actions github-actions bot force-pushed the changeset-release/next branch from 042eb6c to 13a811d Compare December 1, 2023 12:15
@github-actions github-actions bot force-pushed the changeset-release/next branch from 13a811d to 9f409eb Compare December 1, 2023 12:28
@connor-baer connor-baer merged commit 638b4ed into next Dec 1, 2023
3 checks passed
@connor-baer connor-baer deleted the changeset-release/next branch December 1, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants