-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): JA -> JP #2836
fix(icons): JA -> JP #2836
Conversation
Correct country for for Japan is JA, not JP. Fix the Japan country flag.
🦋 Changeset detectedLatest commit: 70d0b61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Renaming the icon is a breaking change and will need to happen in the next major. We can already add the icon under the proper name and deprecate the old icon though.
Size Change: +41 B (+0.01%) Total Size: 672 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 221 221
Lines 12746 12746
Branches 1730 1730
=======================================
Hits 11185 11185
Misses 1506 1506
Partials 55 55 |
@connor-baer updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @matoous , can you add a changeset please ?
630962f
to
11698c2
Compare
@sirineJ done 👀 |
Co-authored-by: sirineJ <[email protected]>
Co-authored-by: sirineJ <[email protected]>
Correct country code for Japan is JA, not JP. Fix the Japan country flag.