Improve spacing of carousel buttons. #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e0c042 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +3 B (0%) Total Size: 670 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
=======================================
Coverage 87.91% 87.91%
=======================================
Files 218 218
Lines 12725 12725
Branches 1726 1726
=======================================
Hits 11187 11187
Misses 1486 1486
Partials 52 52 |
sirineJ
force-pushed
the
fix/carousel-button-styles
branch
from
5510bc7 to
778f1b1
Compare
sirineJ
changed the title
connor-baer
reviewed
Dec 10, 2024
sirineJ
force-pushed
the
fix/carousel-button-styles
branch
from
808b64f to
1e0c042
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sometimes styles bundled by vite have order issues if styles have equal specificity which leads to unexpected component styles. This PR aims to increase specificity to carousel buttons where this issue occurs
Approach and changes
Increase specificity by augmenting class selector.
Definition of done