Add remove toast callback #2823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9830fe5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +23 B (0%) Total Size: 670 kB
ℹ️ View Unchanged
|
vascofg
force-pushed
the
add/remove-toast-callback
branch
from
422a1d3 to
9830fe5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
=======================================
Coverage 87.91% 87.91%
=======================================
Files 218 218
Lines 12725 12729 +4
Branches 1726 1727 +1
=======================================
+ Hits 11187 11191 +4
Misses 1486 1486
Partials 52 52
|
|
There are concerns that the behaviour might introduce UX issues, will close the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow users to dismiss a Toast programmatically. Sometimes this can be beneficial to avoid showing too many toasts or dismissing toasts after navigating away.
Approach and changes
Return a callback function from the
setToastfunction that removes the toast from the context.Definition of done