Add useLocale hook #2787
Merged
Add useLocale hook #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf13f72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +412 B (+0.06%) Total Size: 642 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2787 +/- ##
==========================================
+ Coverage 87.29% 87.32% +0.03%
==========================================
Files 215 216 +1
Lines 12644 12675 +31
Branches 1694 1705 +11
==========================================
+ Hits 11037 11068 +31
Misses 1554 1554
Partials 53 53
|
sirineJ
approved these changes
Nov 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While investigating #2786, I realized that the current usage of the browser locale can lead to hydration errors. During server side rendering, the
getBrowserLocalefunction returns the default locale (en-US). During hydration on the client,getBrowserLocalereturns the user's preferred locale, causing the hydration mismatch.Approach and changes
useLocalehook that returns the default locale during server side rendering and the initial client hydration, and updates it on the next render, thus avoiding the mismatch. Additionally, it listens to thelanguagechangeevent. If a custom locale is passed, it is given priority.Definition of done