Change PlainDateRange to an object #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create new stacking context for the month view to ensure selection stays visible * Always keep border around day cell to prevent flicker on hover
🦋 Changeset detectedLatest commit: 1527145 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +100 B (+0.02%) Total Size: 640 kB
ℹ️ View Unchanged
|
sirineJ
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When building the Calendar component (#2494), I was unsure about the best data type to represent a range of dates: an object or an array. I settled on the array, reasoning that it was easier to sort to ensure the start date comes before the end date.
While working on the DateRangeInput (#2738), I realized that an object is more ergonomic to work with.
Approach and changes
@sumup-oss/intlto format dates now that it supports Temporal objectsDefinition of done