Safely access environment variables #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac3b847 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2737 +/- ##
==========================================
+ Coverage 87.47% 87.48% +0.01%
==========================================
Files 211 212 +1
Lines 11906 11916 +10
Branches 1550 1555 +5
==========================================
+ Hits 10415 10425 +10
Misses 1441 1441
Partials 50 50
|
|
Size Change: +137 B (+0.02%) Total Size: 640 kB
ℹ️ View Unchanged
|
sirineJ
reviewed
Oct 24, 2024
sirineJ
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Vite throws an error when accessing environment variables on
process(except forprocess.env.NODE_ENVwhich is treated as a special case).I tried to add support for
import.meta.envas a fallback forprocess.env, however, Vite replaces it and inlines the environment variables when building Circuit UI. I couldn't find a way to prevent Vite from transforming it.Approach and changes
processnot being defined when accessing custom environment variablesDefinition of done