Improve ESLint migrations for v9 #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 556a891 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
connor-baer
commented
Oct 23, 2024
|
|
||
| fixPackageName(source); | ||
| }, | ||
| [`CallExpression:has(Identifier[name=/(mock|requireActual|importActual)/]):has(Literal[value=/${escapedFrom}(?!-).*/])`]: |
There was a problem hiding this comment.
@sirineJ I modified the matcher to target specific test-related functions instead to be able to support Vitest in addition to Jest.
|
Size Change: 0 B Total Size: 640 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2735 +/- ##
=======================================
Coverage 87.47% 87.47%
=======================================
Files 211 211
Lines 11906 11906
Branches 1550 1550
=======================================
Hits 10415 10415
Misses 1441 1441
Partials 50 50 |
sirineJ
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While testing the upgrade to Circuit UI v9 on a real application, we discovered a couple of shortcomings in the ESLint migration rules.
Approach and changes
no-renamed-propsESLint rule to add theas="strong"prop when migrating the Body's highlight variant to match the previous semanticsrenamed-package-scoperule to cover additional occurrences of package names such as in Jest module mocks.Definition of done