chore(circuit-ui): DSYS-823 | mark phone number & color inputs as stable #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ebd15ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -102 B (-0.02%) Total Size: 638 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2731 +/- ##
=======================================
Coverage 87.49% 87.50%
=======================================
Files 213 213
Lines 11926 11921 -5
Branches 1556 1554 -2
=======================================
- Hits 10435 10431 -4
+ Misses 1441 1440 -1
Partials 50 50
|
connor-baer
changed the title
connor-baer
reviewed
Oct 21, 2024
packages/circuit-ui/components/ColorInput/ColorInput.stories.tsx
Outdated
Show resolved
Hide resolved
connor-baer
force-pushed
the
chore/DSYS-823/mark-phone-color-input-stable
branch
from
a37c49a to
973cdb2
Compare
sirineJ
force-pushed
the
chore/DSYS-823/mark-phone-color-input-stable
branch
from
973cdb2 to
a4c526f
Compare
sirineJ
force-pushed
the
chore/DSYS-823/mark-phone-color-input-stable
branch
from
a4c526f to
e376cc9
Compare
sirineJ
force-pushed
the
chore/DSYS-823/mark-phone-color-input-stable
branch
from
e376cc9 to
9f5535e
Compare
connor-baer
reviewed
Oct 29, 2024
|
|
||
| ## Validations | ||
|
|
||
| Use the `validationHint` prop to communication information about the state of the ColorInput component, along with one of the following validation props: |
There was a problem hiding this comment.
The validationHint prop can also be used without any other validation props to inform users about requirements before they've started entering a value.
sirineJ
force-pushed
the
chore/DSYS-823/mark-phone-color-input-stable
branch
from
6f0e177 to
ebd15ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-823
Purpose
The experimental PhoneNumberInput and ColorInput components were added in Circuit UI v8.9 and v8.13 respectively. Their APIs are finally and many bugs have been fixed, so they are ready to be marked as stable.
Approach and changes
Definition of done