Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable experimental onlyUpdatePeerDependentsWhenOutOfRange changeset option #2727

Merged

Conversation

connor-baer
Copy link
Member

Addresses #ticket-number.

Purpose

When @sumup/circuit-ui has a minor version bump, changesets unnecessarily bumps the peer dependency ranges in the other packages, causing a major version bump.

Approach and changes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner October 17, 2024 12:40
@connor-baer connor-baer requested a review from sirineJ October 17, 2024 12:40
Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: cf7f204

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 0:40am

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (3830252) to head (cf7f204).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2727   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files         210      210           
  Lines       12100    12100           
  Branches     1534     1534           
=======================================
  Hits        10507    10507           
  Misses       1540     1540           
  Partials       53       53           

@connor-baer connor-baer enabled auto-merge (squash) October 17, 2024 12:42
@connor-baer connor-baer disabled auto-merge October 17, 2024 12:53
@connor-baer connor-baer changed the title Prevent unnecessary peer dependency version bumps Enable experimental onlyUpdatePeerDependentsWhenOutOfRange changeset option Oct 17, 2024
@connor-baer connor-baer merged commit 5bace75 into main Oct 17, 2024
14 checks passed
@connor-baer connor-baer deleted the chore/changesets-onlyUpdatePeerDependentsWhenOutOfRange branch October 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant