Improve accessility of the SideNavigation's primary links #2725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The SideNavigation's primary links accept an
isExternal
prop to render an arrow icon to indicate that the link leads to an external page or opens in a new tab and abadge
prop to indicate that new or important content is available at the target page. The icon and badge lack alternative text to make them accessible to visually impaired users.Approach and changes
externalLabel
prop to describe to visually impaired users that the link leads to an external page or opens in a new tab.badge
prop to accept an object with a custom badge color and a label for visually impaired users.Definition of done