chore(design-tokens): DSYS-819 | update typography tokens #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5210a3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* remove old letter-spacing tokens and introduce unique --cui-letter-spacing token. * update typography tokens to their final values. * update some readme files. * Update theme page.
sirineJ
force-pushed
the
chore/DSYS-819/update-typography-tokens
branch
from
ee10df3 to
c61d10c
Compare
|
Size Change: -31 B (0%) Total Size: 636 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2717 +/- ##
==========================================
- Coverage 87.38% 87.27% -0.11%
==========================================
Files 210 210
Lines 12538 12476 -62
Branches 1506 1507 +1
==========================================
- Hits 10956 10889 -67
- Misses 1532 1537 +5
Partials 50 50
|
connor-baer
requested changes
Oct 14, 2024
sirineJ
force-pushed
the
chore/DSYS-819/update-typography-tokens
branch
from
009c4df to
2ae47c9
Compare
connor-baer
reviewed
Oct 14, 2024
connor-baer
reviewed
Oct 15, 2024
There was a problem hiding this comment.
It looks like this file was formatted with different settings from Biome's formatting defaults 🤔
Tab-width should be 2 spaces and there should be a space between the props and JSX closing tag.
sirineJ
force-pushed
the
chore/DSYS-819/update-typography-tokens
branch
from
2487013 to
5210a3f
Compare
connor-baer
approved these changes
Oct 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-819
Purpose
When implementing DSYS-711, the design token values weren’t finalized yet, so I used preliminary values.
Once the values have been finalized in Mapping Typography, we need to update them in the web implementation.
Approach and changes
Check if the token structure can be simplified: for example, do we need component and size-specific tokens for letter-spacings?
Update the token values in circuit-ui/packages/design-tokens/themes/shared.ts at next · sumup-oss/circuit-ui
Remove the
-typographyinfix from typography tokens'namesDefinition of done