-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make temporal-polyfill
a required peer dependency
#2711
Conversation
🦋 Changeset detectedLatest commit: 63fa046 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: 0 B Total Size: 636 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2711 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 210 210
Lines 12539 12539
Branches 1506 1506
=======================================
Hits 10956 10956
Misses 1533 1533
Partials 50 50 |
Purpose
temporal-polyfill
was added as a direct dependency in #2494. This isn't ideal since the package will likely also be a direct dependency of the host project, leading to duplicate installations and conflicting versions.Approach and changes
temporal-polyfill
from the direct dependencies to the peer dependencies. Users will have to explicitly install it.Definition of done