feat: optimised icons #2710
Merged
feat: optimised icons #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1754b90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 210 210
Lines 12000 12000
Branches 1507 1507
=======================================
Hits 10396 10396
Misses 1551 1551
Partials 53 53 |
sirineJ
force-pushed
the
feat/DSYS-814/update-most-used-icons
branch
from
4f55f30 to
d5795d7
Compare
connor-baer
reviewed
Oct 9, 2024
sirineJ
force-pushed
the
feat/DSYS-814/update-most-used-icons
branch
from
d5795d7 to
1754b90
Compare
connor-baer
approved these changes
Oct 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #DSYS-814.
Purpose
Today, when using 24px icons within our buttons they visually look bigger than the textual element within the button. In order to optimize spacing in this case, we are tweaking the iconography grid for a "tighter" one. This change intends to visually balance all elements. We are starting with the top 8 most used icons in our interface and then continue updating our library.
Approach and changes
Update top 8 most used icons with new optimised versions.
Definition of done