Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous integration issues #2706

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

connor-baer
Copy link
Member

Purpose

While showing @sirineJ around the codebase, we noticed a couple of issues.

Approach and changes

  • Consolidate the tests for the SVG files in the icon library.
  • Remove the broken license check. The https://github.com/davglass/license-checker package doesn't support monorepos and is no longer maintained.
  • Fix the codeowners team name

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested review from a team and sirineJ October 4, 2024 15:06
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 0f7016b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 3:11pm

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (fc953de) to head (0f7016b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2706   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files         210      210           
  Lines       12000    12000           
  Branches     1507     1507           
=======================================
  Hits        10396    10396           
  Misses       1551     1551           
  Partials       53       53           

@connor-baer connor-baer merged commit a48edfa into main Oct 4, 2024
13 of 14 checks passed
@connor-baer connor-baer deleted the chore/consolidate-icon-tests branch October 4, 2024 15:24
@connor-baer connor-baer changed the title Fix continous integration issues Fix continuous integration issues Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants