Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated initialSortedRow Table prop #2658

Merged
merged 2 commits into from
Sep 4, 2024

Update packages/circuit-ui/components/NotificationBanner/Notification…

1f74b8d
Select commit
Loading
Failed to load commit list.
Merged

Remove the deprecated initialSortedRow Table prop #2658

Update packages/circuit-ui/components/NotificationBanner/Notification…
1f74b8d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2024 in 0s

87.36% (-0.01%) compared to 540d8f8, passed because coverage increased by -0.01% when compared to adjusted base (87.36%)

View this Pull Request on Codecov

87.36% (-0.01%) compared to 540d8f8, passed because coverage increased by -0.01% when compared to adjusted base (87.36%)

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (540d8f8) to head (1f74b8d).

Files with missing lines Patch % Lines
...mponents/NotificationBanner/NotificationBanner.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2658      +/-   ##
==========================================
- Coverage   87.37%   87.36%   -0.01%     
==========================================
  Files         210      210              
  Lines       12536    12528       -8     
  Branches     1508     1504       -4     
==========================================
- Hits        10953    10945       -8     
  Misses       1533     1533              
  Partials       50       50              
Files with missing lines Coverage Δ
packages/circuit-ui/components/Table/Table.tsx 79.19% <100.00%> (-0.92%) ⬇️
...mponents/NotificationBanner/NotificationBanner.tsx 94.44% <0.00%> (ø)