New typography #2653
Merged
New typography #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 338d1a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2653 +/- ##
==========================================
+ Coverage 86.60% 87.20% +0.59%
==========================================
Files 208 210 +2
Lines 11882 12415 +533
Branches 1498 1511 +13
==========================================
+ Hits 10290 10826 +536
+ Misses 1540 1538 -2
+ Partials 52 51 -1
|
connor-baer
force-pushed
the
feature/new-typography
branch
from
db7c357 to
ee3d14f
Compare
marcelvoss
approved these changes
Aug 19, 2024
connor-baer
force-pushed
the
feature/new-typography
branch
from
ee3d14f to
7242dd8
Compare
5 tasks
connor-baer
force-pushed
the
feature/new-typography
branch
from
95e438b to
e847c57
Compare
|
Size Change: +2.79 kB (+0.44%) Total Size: 632 kB
ℹ️ View Unchanged
|
5 tasks
5 tasks
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-708 and DSYS-711.
Purpose
One of the biggest challenges in our user interfaces today is how to convene a clear hierarchy of the elements presented on a screen. Text plays a critical role in tackling this challenge, and currently our typographic scale has several limitations to our developers' and designers' needs. This is particularly crucial for black-and-white interfaces, where the absence of color places greater emphasis on typography to convey hierarchy and guide the user's eye. To address this, we need to establish a clearer hierarchy through a more consistent and scalable typographic system, ensuring better readability and comprehension across different platforms.
Approach and changes
no-renamed-propsand the newno-deprecated-custom-propertiesESLint and Stylelint rules.s, and the BodyLarge component has been deprecated in favor of the Body component in sizel.variantprop in favor of the newweightandcolorprops.Warning
The typography tokens and new component APIs are not final and subject to breaking changes during the prerelease phase.
Definition of done