New DateInput component #2645
Merged
New DateInput component #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 804f19f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2645 +/- ##
==========================================
+ Coverage 87.49% 87.82% +0.32%
==========================================
Files 213 218 +5
Lines 11926 12615 +689
Branches 1556 1695 +139
==========================================
+ Hits 10435 11079 +644
- Misses 1441 1486 +45
Partials 50 50
|
connor-baer
force-pushed
the
feature/date-input
branch
from
3188d3b to
e01db7f
Compare
|
Size Change: +7.08 kB (+1.11%) Total Size: 647 kB
ℹ️ View Unchanged
|
connor-baer
force-pushed
the
feature/date-input
branch
from
60dd522 to
21a3279
Compare
connor-baer
force-pushed
the
feature/date-input
branch
from
21a3279 to
35dcf3a
Compare
connor-baer
force-pushed
the
feature/date-input
branch
from
35dcf3a to
2629de4
Compare
connor-baer
force-pushed
the
feature/date-input
branch
from
2629de4 to
a236a84
Compare
connor-baer
force-pushed
the
feature/date-input
branch
from
c18223d to
a52c8c0
Compare
|
I've refactored the internals significantly:
|
connor-baer
force-pushed
the
feature/date-input
branch
from
f283524 to
a075ae0
Compare
sirineJ
reviewed
Oct 28, 2024
sirineJ
reviewed
Oct 28, 2024
| } | ||
|
|
||
| // Don't allow editing the value when the input is disabled or read-only | ||
| if (input.disabled || input.readOnly) { |
There was a problem hiding this comment.
why do we need to be explicit about this if the input is disabled ?
There was a problem hiding this comment.
For some reason, the onKeyDown event handler is still called when the input disabled. Surprised me as well 😳
sirineJ
reviewed
Oct 28, 2024
| let newValue: number; | ||
|
|
||
| const getValue = (offset: number) => | ||
| value ? shiftInRange(value, offset, min, max) : defaultValue; |
sirineJ
reviewed
Oct 28, 2024
| month: { | ||
| value: values.month, | ||
| 'aria-valuetext': values.month | ||
| ? [values.month, getMonthName(values.month, locale)].join(', ') |
sirineJ
reviewed
Oct 28, 2024
| @@ -45,7 +45,7 @@ import { | |||
| type SidePanelContextProps, | |||
| } from './SidePanelContext.js'; | |||
|
|
|||
| vi.mock('../../hooks/useMedia'); | |||
| vi.mock('../../hooks/useMedia/index.js'); | |||
There was a problem hiding this comment.
The final ES module spec requires full file paths (ref). I'm surprised that this worked before; I assume Vite does some magic under the hood to support ambiguous file paths.
sirineJ
approved these changes
Oct 28, 2024
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-656.
Purpose
input[type="date"]is a rare example of a native element that doesn't meet accessibility requirements and warrants a custom component. The native component also lacks customizability to disable specific dates or allow the selection of a date range.Approach and changes
Definition of done