Match interactive color tokens to default values #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: fad1c1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
=======================================
Coverage 86.73% 86.73%
=======================================
Files 209 209
Lines 11902 11902
Branches 1531 1531
=======================================
Hits 10323 10323
Misses 1526 1526
Partials 53 53
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The tweaks to the color tokens in #2551 make the buttons look washed out in their hovered and pressed states because both the background and foreground colors change, significantly reducing the contrast between them.
We want to avoid further large-scale changes to the color tokens without extensive testing. In the future, we'll consider whether interactive foreground color variants should be used on interactive background colors at all.
Approach and changes
fg-normal,fg-subtle,fg-on-strong, andfg-on-strong-subtlecolor tokens to their default valuesDefinition of done