Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PhoneNumberInput styles #2578

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Improve PhoneNumberInput styles #2578

merged 3 commits into from
Jun 13, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jun 12, 2024

Purpose

I discovered some style issues while integrating the new PhoneNumberInput into an application.

Approach and changes

  • Balance widths of phone number input fields
  • Fix input outline layering on hover

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:28pm

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: c408a07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (4b5f125) to head (c408a07).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2578   +/-   ##
=======================================
  Coverage   88.29%   88.30%           
=======================================
  Files         206      206           
  Lines       22805    22803    -2     
  Branches     1527     1527           
=======================================
  Hits        20136    20136           
+ Misses       2617     2615    -2     
  Partials       52       52           
Files Coverage Δ
...i/components/PhoneNumberInput/PhoneNumberInput.tsx 95.29% <50.00%> (+0.44%) ⬆️

@connor-baer connor-baer marked this pull request as ready for review June 13, 2024 09:17
@connor-baer connor-baer requested a review from a team as a code owner June 13, 2024 09:17
@connor-baer connor-baer merged commit 3c026f3 into main Jun 13, 2024
12 of 14 checks passed
@connor-baer connor-baer deleted the bugfix/phone-number-input branch June 13, 2024 09:18
@connor-baer connor-baer mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant