Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename component sizes #2311

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Rename component sizes #2311

merged 7 commits into from
Nov 30, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Nov 30, 2023

Purpose

I renamed the Button sizes in #2307. Four other components use the same old naming scheme. For consistency, their size values should be renamed as well.

Approach and changes

Rename the following size values (medium is always the default):

  • Avatar: giga → small, yotta → medium
  • ProgressBar: byte → small, kilo → medium, mega → large
  • SelectorGroup: kilo → small, mega → medium, flexible (unchanged)
  • Spinner: byte → small, kilo → medium, giga → large

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Nov 30, 2023

🦋 Changeset detected

Latest commit: 9e23491

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sumup/circuit-ui Minor
@sumup/eslint-plugin-circuit-ui Major
@sumup/astro-template-circuit-ui Patch
@sumup/remix-template-circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 2:35pm

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #2311 (9e23491) into canary (a51de39) will decrease coverage by 0.09%.
The diff coverage is 80.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2311      +/-   ##
==========================================
- Coverage   97.06%   96.98%   -0.09%     
==========================================
  Files         251      251              
  Lines       20062    20170     +108     
  Branches     1263     1263              
==========================================
+ Hits        19474    19562      +88     
- Misses        574      596      +22     
+ Partials       14       12       -2     
Files Coverage Δ
packages/circuit-ui/components/Button/Button.tsx 90.08% <100.00%> (-0.17%) ⬇️
...ckages/circuit-ui/components/Carousel/Carousel.tsx 99.55% <100.00%> (ø)
...cuit-ui/components/SelectorGroup/SelectorGroup.tsx 97.34% <100.00%> (ø)
.../circuit-ui/components/ProgressBar/ProgressBar.tsx 93.95% <86.48%> (-2.02%) ⬇️
...ckages/circuit-ui/components/Selector/Selector.tsx 95.51% <85.71%> (-1.94%) ⬇️
packages/circuit-ui/components/Spinner/Spinner.tsx 93.33% <88.09%> (-6.67%) ⬇️
packages/circuit-ui/components/Avatar/Avatar.tsx 87.24% <60.52%> (-1.99%) ⬇️

Base automatically changed from feature/button-deprecations to canary November 30, 2023 13:51
@connor-baer connor-baer marked this pull request as ready for review November 30, 2023 14:53
@connor-baer connor-baer requested a review from a team as a code owner November 30, 2023 14:53
@connor-baer connor-baer merged commit 39466c0 into canary Nov 30, 2023
9 of 12 checks passed
@connor-baer connor-baer deleted the feature/size-names branch November 30, 2023 14:57
@connor-baer connor-baer mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant