-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new button design #2299
Conversation
🦋 Changeset detectedLatest commit: 30af956 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## canary #2299 +/- ##
==========================================
+ Coverage 96.93% 96.97% +0.04%
==========================================
Files 251 252 +1
Lines 20171 20256 +85
Branches 1246 1262 +16
==========================================
+ Hits 19552 19643 +91
+ Misses 607 600 -7
- Partials 12 13 +1
|
3d88937
to
7f6cb3d
Compare
0d1abad
to
338faf8
Compare
338faf8
to
34f0ded
Compare
dcc2045
to
12624f7
Compare
00a2ca5
to
bcb97a9
Compare
ed00bf9
to
80f96a4
Compare
Something's broken when globally linting the package.
7cd5487
to
774404a
Compare
Purpose
This update aims to prepare the Button component for the anticipated color change to black&white, align with Solo UI, improve usability, and extend usage guidelines.
Approach and changes
disabled
attribute has been replaced with thearia-disabled
attribute which enables the disabled element to receive focus and be perceived by screenreader users. Interactions with the disabled element are still blocked by a dummy click handler.Definition of done