Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade template to Next.js 14 #2290

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Upgrade template to Next.js 14 #2290

merged 3 commits into from
Nov 10, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Nov 10, 2023

Purpose

Next.js 14 was released recently. More importantly, Next.js 13.5 added the experimental optimizePackageImports config which unlocks the use of Circuit UI components in React server components.

Approach and changes

  • Upgrade the create-next-app template to Next.js 14
  • Migrate the template from the pages to the app folder
    • Use the new metadata API
    • Remove the layouts folder to avoid confusion with layout files
    • Remove the default custom error pages to encourage developers to customize them.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner November 10, 2023 13:34
@connor-baer connor-baer requested review from tareqlol and removed request for a team November 10, 2023 13:34
Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 7050c05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/cna-template Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Nov 10, 2023 1:34pm

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2290 (7050c05) into main (960ad6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2290   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         251      251           
  Lines       19862    19862           
  Branches     1224     1224           
=======================================
  Hits        19297    19297           
  Misses        551      551           
  Partials       14       14           

@connor-baer connor-baer enabled auto-merge (squash) November 10, 2023 13:39
@connor-baer connor-baer disabled auto-merge November 10, 2023 15:33
@connor-baer connor-baer merged commit 7a2c36d into main Nov 10, 2023
10 checks passed
@connor-baer connor-baer deleted the feature/cna-14 branch November 10, 2023 15:33
This was referenced Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant