Scroll overflowing content in the Popover #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f149d07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
connor-baer
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2289 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 251 251
Lines 19847 19862 +15
Branches 1223 1224 +1
=======================================
+ Hits 19282 19297 +15
Misses 551 551
Partials 14 14
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The profile menu in the TopNavigation exhibits a bug when the number of profile items is large, and the vertical space to display the items is limited (e.g., at shorter screen resolutions). The Popover, the component used to render the profile menu, is cut off, preventing access to the last items.
Approach and changes
sizemiddleware to the Popover. If the Popover content exceeds the available vertical space, it becomes scrollable.Definition of done