Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Astro template #2230

Merged
merged 14 commits into from
Nov 13, 2023
Merged

Add an Astro template #2230

merged 14 commits into from
Nov 13, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Aug 31, 2023

Purpose

Astro is a new web framework that has been gaining popularity thanks to its innovative framework-agnostic island architecture.

Approach and changes

  • Initialized an Astro app using npx create-astro@latest
  • Installed the design system dependencies
  • Modified the GitHub workflow to test the Astro template in addition to the Next.js and Remix ones
  • Customized the template homepage:

Screenshot 2023-11-13 at 10-29-43 Welcome to Circuit UI Astro

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

🦋 Changeset detected

Latest commit: f81cd86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/astro-template-circuit-ui Major
@sumup/remix-template-circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:03am

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed.

@github-actions github-actions bot added the stale label Oct 31, 2023
@connor-baer
Copy link
Member Author

I'm back from my sabbatical and will continue working on this PR soon.

@connor-baer connor-baer marked this pull request as ready for review November 13, 2023 09:56
@connor-baer connor-baer requested a review from a team as a code owner November 13, 2023 09:56
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team November 13, 2023 09:56
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2230 (f81cd86) into main (041c23d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2230   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         251      251           
  Lines       19862    19862           
  Branches     1224     1224           
=======================================
  Hits        19297    19297           
  Misses        551      551           
  Partials       14       14           

@connor-baer connor-baer merged commit b736ac7 into main Nov 13, 2023
10 checks passed
@connor-baer connor-baer deleted the feature/template-astro branch November 13, 2023 10:11
@connor-baer connor-baer mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant