Hide Button's loading label (#2247)

sumup-oss · Sep 11, 2023 · 390d1e4 · 390d1e4 · vercel · Sep 11, 2023
1 parent 4adbdd5
commit 390d1e4
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/.changeset/six-buttons-dream.md b/.changeset/six-buttons-dream.md
@@ -0,0 +1,5 @@
+---
+'@sumup/circuit-ui': patch
+---
+
+Hid the Button's loading label in JSDOM environments.
diff --git a/packages/circuit-ui/components/Button/Button.tsx b/packages/circuit-ui/components/Button/Button.tsx
@@ -151,7 +151,11 @@ export const Button = forwardRef<any, ButtonProps>(
         )}
         ref={ref}
       >
-        <Spinner className={classes.spinner} size="byte">
+        <Spinner
+          className={classes.spinner}
+          size="byte"
+          aria-hidden={!isLoading}
+        >
           <span className={utilityClasses.hideVisually}>{loadingLabel}</span>
         </Spinner>
         <span className={classes.content}>

diff --git a/packages/circuit-ui/components/Sidebar/__snapshots__/Sidebar.spec.tsx.snap b/packages/circuit-ui/components/Sidebar/__snapshots__/Sidebar.spec.tsx.snap
@@ -101,6 +101,7 @@ exports[`Sidebar > should render and match snapshot when open 1`] = `
     type="button"
   >
     <span
+      aria-hidden="true"
       class="_base_2b3edd _byte_2b3edd _spinner_892426"
     >
       <span
@@ -219,6 +220,7 @@ exports[`Sidebar > should render and match the snapshot when closed 1`] = `
     type="button"
   >
     <span
+      aria-hidden="true"
       class="_base_2b3edd _byte_2b3edd _spinner_892426"
     >
       <span

diff --git a/...cuit-ui/components/Sidebar/components/CloseButton/__snapshots__/CloseButton.spec.tsx.snap b/...cuit-ui/components/Sidebar/components/CloseButton/__snapshots__/CloseButton.spec.tsx.snap
@@ -24,6 +24,7 @@ exports[`CloseButton > styles > should render and match snapshot when not visibl
   type="button"
 >
   <span
+    aria-hidden="true"
     class="_base_2b3edd _byte_2b3edd _spinner_892426"
   >
     <span
@@ -83,6 +84,7 @@ exports[`CloseButton > styles > should render and match snapshot when visible 1`
   type="button"
 >
   <span
+    aria-hidden="true"
     class="_base_2b3edd _byte_2b3edd _spinner_892426"
   >
     <span