Support doctrine/persistence ^3 #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went through the upgrade notes on https://github.com/doctrine/persistence/blob/3.4.x/UPGRADE.md, not affected by BC breaking changes.
|
@StephenBeirlaen Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
To run Sulu with this bundle on Symfony 6.4, one of the constrained packages was
doctrine/persistence, which was still locked to ^2 here, while ^3 is required.I went through the upgrade notes on https://github.com/doctrine/persistence/blob/3.4.x/UPGRADE.md. This bundle does not seem to be affected by any BC breaking changes.
Note: Linting errors do not seem to be caused by this PR.
Why?
Move towards supporting Symfony 6.4
BC Breaks/Deprecations
There should be none.