Fix create document for user when sub does not match but email does #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a document on behalf of a user via the server-to-server API, a special edge case was broken that should should never happen but happens in our OIDC federation because one of the provider modifies the users "sub" each time they login. We end-up with existing users for who the email matches but not the sub. They were not correctly handled. I made a few additional fixes and improvements to the endpoint.
We have changed the project's name from "impress" to "docs" but haven't replace all occurrences of impress in the project because we want to be careful of the consequences on deployments. The name of the docker compose project was different for the pyling make target which was causing this bug. Let's rename if without waiting.
AntoLC
approved these changes
Jan 10, 2025
AntoLC
reviewed
Jan 10, 2025
| email = validated_data["email"] | ||
| user = models.User.objects.filter(email=email).first() |
There was a problem hiding this comment.
user could be null actually here, so the creator could be null when you create the document, isn't it ?
There was a problem hiding this comment.
yep. This is being handled here: https://github.com/suitenumerique/docs/blob/main/src/backend/core/models.py#L245
When the creator is null it will be filled-in when the invitation completes...
There was a problem hiding this comment.
Question on my side, why not calling :
User.objects.get(email__iexact=email)
As here, and handle it if errors occur
Comment on lines
-282
to
+288
| raise exceptions.APIException(detail="could not convert content") from err | ||
| raise serializers.ValidationError( | ||
| {"content": ["Could not convert content"]} | ||
| ) from err |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When creating a document on behalf of a user via the server-to-server API, a special edge case was broken that should never happen but happens in our OIDC federation because one of the provider modifies the users "sub" each time they login.
We ended-up with existing users for who the email matches but not the sub. They were not correctly handled.
Proposal
Get the user by its email like we do during authentication if activated in settings.
Made a few additional fixes and improvements to the endpoint.