Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(frontend) enhance UI components and improve document #524

Merged
merged 9 commits into from
Dec 24, 2024
Merged

✨(frontend) enhance UI components and improve document #524

merged 9 commits into from
Dec 24, 2024

Conversation

PanchoutNathan
Copy link
Collaborator

@PanchoutNathan PanchoutNathan commented Dec 20, 2024 •
edited
Loading

Purpose

  • Updated color tokens and styles across various components for better consistency and accessibility.
  • Refactored DropdownMenu and Button components to improve layout and responsiveness.
  • Enhanced document sharing features with improved role management and user invitation handling.
  • Introduced new LeftPanelDocContent component for displaying document details in the left panel.
  • Adjusted padding and margin settings in multiple components for a more cohesive design.
  • Updated SVG assets for better visual representation and alignment with the new design tokens.
  • Cleaned up unused imports and optimized component structures for maintainability.

@PanchoutNathan PanchoutNathan force-pushed the new-ui/fine-tunning branch 2 times, most recently from cb996ca to 15f1d05 Compare December 23, 2024 09:38
@PanchoutNathan PanchoutNathan self-assigned this Dec 23, 2024
AntoLC
AntoLC reviewed Dec 23, 2024
View reviewed changes
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelDocContent.tsx Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelContent.tsx Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelContent.tsx Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/docs/docs-grid/components/SimpleDocItem.tsx Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/docs/docs-grid/components/SimpleDocItem.tsx Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/utils.ts Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteEditor.tsx Outdated Show resolved Hide resolved
src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/docs/doc-share/component/DocShareModal.tsx Outdated Show resolved Hide resolved
src/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGrid.tsx Outdated Show resolved Hide resolved
AntoLC
AntoLC approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good job.

@PanchoutNathan
✨(frontend) update color tokens and styles
d8e7b9f 
- Modified color tokens for danger and info categories to enhance visual
consistency and accessibility.
- Updated button and modal styles, including adjustments to padding and
dimensions for improved layout.
- Replaced font files for Marianne with updated versions to ensure
better typography.
@PanchoutNathan
✨(frontend) enhance left panel components
3bea132 
- Updated padding and radius styles in LeftPanelTargetFilters and
LeftPanelFavorites for improved layout consistency.
- Introduced LeftPanelDocContent component to display document details
when navigating to specific documentation pages.
- Enhanced LeftPanelContent to conditionally render LeftPanelDocContent
based on the current route.
- Adjusted LeftPanelHeader button colors for better visual hierarchy.
- Refactored MainLayout padding for a more responsive design.
@PanchoutNathan
✨(frontend) enhance document grid
561351e 
- Updated the layout and styling of the DocsGrid and DocsGridItem
components for improved responsiveness and visual consistency.
- Added a new background prop to the UserAvatar component for
customizable user avatars.
- Enhanced the DocsGridActions component to include a share option,
allowing users to share documents easily.
- Refactored SVG assets for pinned and simple documents to improve their
dimensions and visual representation.
- Improved the SimpleDocItem component to display document update times
and access indicators more effectively.
- Adjusted padding and spacing across various components to enhance
overall user experience.
@PanchoutNathan
✨(frontend) enhance QuickSearch components
f8398b7 
- Updated QuickSearchItemContent to ensure full width for better layout
consistency.
- Adjusted padding in QuickSearchStyle for improved spacing and visual
hierarchy.
- Refactored DocSearchItem to utilize Box component for consistent
styling and layout.
- Removed unused imports in DocSearchItem to streamline the codebase.
@PanchoutNathan
✨(frontend) enhance UI components and improve styling
8a9134d 
- Updated DropdownMenu and ButtonLogin components for better
accessibility and visual consistency.
- Refactored Header and Title components to utilize new theming and
spacing tokens.
- Enhanced LanguagePicker styles for improved user experience.
- Introduced new utility functions in doc-management for better handling
of ProseMirror nodes and Yjs integration.
- Cleaned up unused imports and adjusted component styles for overall
code maintainability.
@PanchoutNathan
✨(frontend) enhance document editor and header components
765b4d6 
- Improved styling for headings in BlockNoteEditor for better visual
hierarchy.
- Adjusted padding in DocEditor and DocHeader based on device type for
responsive design.
- Updated DocTitle and ModalExport components to enhance typography and
spacing.
- Refactored DocToolBox to improve share button functionality and access
display.
- Enhanced versioning modal with better layout and accessibility
features.
- Cleaned up unused imports and optimized component structures for
maintainability.
@PanchoutNathan
✨(frontend) enhance document sharing components
02706cd 
- Refactored DocShareAddMemberList to simplify button styling and
improve loading state handling.
- Updated DocShareAddMemberListItem and DocShareMemberItem to enhance
spacing and button color for better visual consistency.
- Improved DocShareInvitationItem and SearchUserRow with new theming and
spacing tokens for a more cohesive design.
- Adjusted padding and layout in DocShareModal and DocShareModalFooter
for improved responsiveness.
- Enhanced DocVisibility component with updated padding and text styling
for better readability.
- Cleaned up unused imports and optimized component structures for
maintainability.
@PanchoutNathan
✨(frontend) enhance document interaction tests
e7948a2 
- Updated test cases to improve accessibility by replacing 'more_vert'
with 'more_horiz' for action buttons across various components.
- Refactored document deletion confirmation messages to use consistent
heading roles for better visibility.
- Simplified keyboard interactions in document table content tests for
improved clarity.
- Adjusted visibility checks for the share button to utilize more
descriptive labels.
- Cleaned up test code for maintainability and consistency.
@PanchoutNathan PanchoutNathan merged commit 41f8951 into main-new-ui Dec 24, 2024
10 of 11 checks passed
@PanchoutNathan PanchoutNathan deleted the new-ui/fine-tunning branch December 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoLC AntoLC AntoLC approved these changes

Assignees

@PanchoutNathan PanchoutNathan

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PanchoutNathan @AntoLC