Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(frontend) change visibility options order in dropdown menu #441

Closed
wants to merge 3 commits into from

Conversation

vinhyan
Copy link

@vinhyan vinhyan commented Nov 21, 2024

Purpose

This PR updates the option order to the following:

  1. Restricted
  2. Authenticated
  3. Public

(issue #397 )

Proposal

The options can be found from LinkReach in /src/frontend/apps/impress/src/features/docs/doc-management/types.tsx. Reordering them here will directly impact how they are displayed in the UI.

Change the option order to:
1. Restricted
2. Authenticated
3. Public
@vinhyan
Copy link
Author

vinhyan commented Nov 21, 2024

Hi @virgile-dev, this is ready for review. Thanks!

@virgile-dev
Copy link
Collaborator

@PanchoutNathan did you had this in mind for the new UI ?

@virgile-dev virgile-dev closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants