Fixes #111 #146
Merged
Fixes #111 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppeg
reviewed
Oct 29, 2017
README.md
Outdated
|
|
||
| * https://github.com/simonsmith/suitcss-components-form-field | ||
| * https://github.com/giuseppeg/suitcss-components-icon | ||
| * https://github.com/giuseppeg/suitcss-components-arrow |
There was a problem hiding this comment.
mine repo are old can you replace the two links above with https://github.com/giuseppeg/suitcss-toolkit (not maintained anyway)
README.md
Outdated
| * https://github.com/simonsmith/suitcss-utils-list | ||
| * https://github.com/simonsmith/suitcss-utils-image | ||
| * https://github.com/frekyll/suitcss-utils-spacing | ||
|
|
||
| ## Development |
There was a problem hiding this comment.
can you move this section up, before Example ?
There was a problem hiding this comment.
I made those changes.
simonsmith
reviewed
Oct 30, 2017
README.md
Outdated
| @@ -68,6 +68,22 @@ the `-w` flag e.g. `npm run build -- -w`. | |||
| Refer to the [SUIT theme](https://github.com/suitcss/theme) for a more thorough | |||
| example. | |||
|
|
|||
| ## Community Packages | |||
|
|
|||
| Easily extend SUIT CSS with these third-party packages. | |||
There was a problem hiding this comment.
I think we could probably lose these sentence. Otherwise looks good!
There was a problem hiding this comment.
I removed line 73. Is that what you were referring to?
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a section in the main docs to address issue #111.