Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial unit tests for cleardep #1

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Initial unit tests for cleardep #1

wants to merge 9 commits into from

Conversation

rmst
Copy link

@rmst rmst commented Sep 2, 2014

No extra features or bugfixes jet

@seba--
Copy link
Member

seba-- commented Sep 3, 2014

Please resolve the following two issues first.

  1. Can you rename TestCompilationUnit to CompilationUnitMock?
  2. The new source folder test should be registered in some project configuration file, right? Please also commit that file. Futhermore, build.properties lists source folders and probably needs adaption.

@rmst
CompilationUnitTest completed and renamed to CompilationUnitMock
7d3a68b 
build.properties updated
@rmst
1. addModuleDependency(..) now checks for circularity
6e45bce 
2. corresponding unit test added
3. addCirculrModuleDependency(..) depreciated
@rmst
corrected addModuleDependency and corresponding test
b10a422
@rmst
CompilationUnitMock:
51e3967 
-corrected visitor-tests
-minor other changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmst @seba--