fix: sha padding asserts and other bug fixes #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ use super::digest_hint::SHADigestHint; | |||
| use super::proof_hint::SHAProofHint; | |||
| use super::request::SHARequest; | |||
| use super::SHA; | |||
| use crate::frontend::hint::synchronous::Async; | |||
| use crate::prelude::*; | |||
|
|
|||
| impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> { | |||
There was a problem hiding this comment.
nit: Add function description as a doc comment.
Comment on lines
256
to
258
| #[test] | ||
| #[cfg_attr(feature = "ci", ignore)] | ||
| fn test_sha_padding_variable() {} |
| bits.push(self.api._true()); | ||
|
|
||
| let l = bits.len() - 1; | ||
| let k = 512 - (l + 1 + 64) % 512; // number of padding bits you need |
There was a problem hiding this comment.
nit: Comment should be on top of this line, and should not use "you"
| #[derive(Debug, Clone)] | ||
| pub enum SHARequest { | ||
| /// A message of fixed length. | ||
| Fixed(Vec<ByteVariable>), | ||
| /// A message of variable length, with the actual legnth given by the Variable. | ||
| /// A message of variable length, represented by a tuple `(total_message, lengh, chunk_index)`. |
There was a problem hiding this comment.
last_chunk is used elsewhere in the codebase, is there a reason why chunk_index is used here?
ratankaliani
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.