FunctionGatewayV2 #204
FunctionGatewayV2 #204
Conversation
contracts/src/FunctionGatewayV2.sol
Outdated
| mapping(bytes32 => address) functionIdToVerifier; | ||
|
|
||
| function callbackRequestV1( | ||
| bytes32 _functionId, |
There was a problem hiding this comment.
I feel like a better name for this function is something like requestWithContextV1
There was a problem hiding this comment.
and likewise fulfillRequestWithContextV1
contracts/src/FunctionGatewayV2.sol
Outdated
| delete requests[_requestId]; | ||
| } | ||
|
|
||
| function storeRequestV1( |
There was a problem hiding this comment.
if most users are going to use this, we should just call it requestV1 imo
contracts/src/FunctionGatewayV2.sol
Outdated
| } | ||
| } | ||
|
|
||
| function verifyStored( |
There was a problem hiding this comment.
the name of this function should be one word, like verify or check or something
contracts/src/FunctionGatewayV2.sol
Outdated
| // Default case | ||
| oracle[_functionId][inputHash] = outputHash; | ||
|
|
||
| if (_address != address(0)) { |
There was a problem hiding this comment.
IMO we should have the callback functionality in a separate function rather than shove it in here
contracts/src/FunctionGatewayV2.sol
Outdated
| revert CallbackFailed(_callbackAddress, _callbackSelector); | ||
| } | ||
|
|
||
| delete requests[_requestId]; |
There was a problem hiding this comment.
Not relevant to the changes but please remember to delete requests[_requestId]; before the .call
| return; | ||
| } | ||
|
|
||
| VerifiedCall currentVerifiedCall = VerifiedCall({ |
There was a problem hiding this comment.
I'm really surprised if saving currentVerifiedCall to memory like this works, pretty sure it needs to be a storage slot.
No description provided.